Skip to content
Submitted 5 months ago

A FAQ accordion

Caelus•520
@Caelus111
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

This one is kinda tricky, because I had to search how to do it and then do it my way because I built the html differently than other tutorials.

Next time, I would like to build it myself with my own way of thinking

What challenges did you encounter, and how did you overcome them?

i was originaly gonna do everything with js, but that was the hardest way because of the way I built the html, so I did some changes in the UI in css and the dislay changed in JS which was the easiest way to do it

What specific areas of your project would you like help with?

It's not perfect so If you have a better way tell me!

Community feedback

  • Alex•3,130
    @Alex-Archer-IPosted 5 months ago

    Hi!

    There no need in this work to use header and nav tags. Those tags have a specific semantic meanings - they represent a top part of the site which is the same for all it's pages. nav in turn should contain navigation menu and nothing else. This project doesn't have all that =)

    And that is why header and main should be a sibling tags.

    The box-shadow property have a very wide browser support now - more than 98%. So, you don't have to add vendor prefix for it.

    Oh, and you have a few extra constants in your code. Guess you planned more complex algorithm initially =)

    Overall you've done quite a neat work, keep doing =)

    0
    Caelus•520
    @Caelus111Posted 5 months ago

    @Alex-Archer-I Thank you for taking your time to write such a constructed feedback.

    I will change what should be changed to make the code a bit cleaner, again Thank you for the important information. 😁

    1
    Alex•3,130
    @Alex-Archer-IPosted 5 months ago

    @Caelus111

    Thank you for calling my grunting a constructed feedback =) Hope you really found something useful here.

    The first part is important though. Semantic and all of that =)

    0
    Caelus•520
    @Caelus111Posted 5 months ago

    @Alex-Archer-I At all! I appreciate the important advices from someone with more experience than me because I am self-learning and feedback is important for it.

    1
    Alex•3,130
    @Alex-Archer-IPosted 5 months ago

    @Caelus111

    Oh, the irony is that I'm self-learning too. Humanities degree isn't a big help here =)

    So, good luck. Feel free to ask, comment or something if you need =)

    0
    Caelus•520
    @Caelus111Posted 5 months ago

    @Alex-Archer-I it's better to work with other people some time rather than alone, so thank you brother.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord