@Alex-Archer-I
Posted
Hi!
There no need in this work to use header and nav tags. Those tags have a specific semantic meanings - they represent a top part of the site which is the same for all it's pages. nav in turn should contain navigation menu and nothing else. This project doesn't have all that =)
And that is why header and main should be a sibling tags.
The box-shadow property have a very wide browser support now - more than 98%. So, you don't have to add vendor prefix for it.
Oh, and you have a few extra constants in your code. Guess you planned more complex algorithm initially =)
Overall you've done quite a neat work, keep doing =)
@Caelus111
Posted
@Alex-Archer-I Thank you for taking your time to write such a constructed feedback.
I will change what should be changed to make the code a bit cleaner, again Thank you for the important information. 😁
@Alex-Archer-I
Posted
@Caelus111
Thank you for calling my grunting a constructed feedback =) Hope you really found something useful here.
The first part is important though. Semantic and all of that =)
@Caelus111
Posted
@Alex-Archer-I At all! I appreciate the important advices from someone with more experience than me because I am self-learning and feedback is important for it.
@Alex-Archer-I
Posted
@Caelus111
Oh, the irony is that I'm self-learning too. Humanities degree isn't a big help here =)
So, good luck. Feel free to ask, comment or something if you need =)
@Caelus111
Posted
@Alex-Archer-I it's better to work with other people some time rather than alone, so thank you brother.
