Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

A Div tag as a container using Css display block

OLASUNKANMIโ€ข 20

@Ademolaolas18

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


The whole process went well without stress, it's my first time working on front-mentor challenge and its so soft and amazing.

Community feedback

Angela Mooreโ€ข 160

@Cyber-Chic

Posted

Wonderful job completing your first challenge! ๐Ÿ˜Š

I have some recommendations that may improve your site:

  • Change your background color. You used a slightly different color. To do this I would change your code from:
background-color: #e7ebf9;

to

background-color: hsl(218, 44%, 22%);
  • Add a <h1> element to your code. All sites should include a minimum of one <h1> element to indicate the the most important (or highest-level) heading on a page. To fix this, you could change your <h4> element to an <h1> element.

  • Add a <main> tag around the main content on your webpage. All web pages should include one <main> tag. This is a semantic HTML element that defines the main content on a page such as primary sections, text, articles, etc.

Example:

<main>
  <div class='container'>
    <h1>Main heading text</h1>
    <p>paragraph text</p>
  </div>
</main>
  • Your code does not look formatted. Formatting your code can make it easier to read. You can format your code using an automatic code formatter such as Prettier ยท Opinionated Code Formatter.

I hope this is helpful! Great work & Happy Coding!

-Angie

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord