A bit responsive using media query.

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Agu Jonas, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  2.Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

  3.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  4.Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  0
• 

  Samuel M. Setiawan•200

  @samuelms21Posted about 2 years ago

  Hey there, nice work with your project. There is a tiny improvement that you can do, you can add external fonts to your HTML document from Google Fonts. Here's how:

  • Open Google Fonts and search for Outfit (the font-family attached in style-guide.md
  • You can select the required font weights, and import it to your CSS
  • Copy and paste this code to the top of your CSS document:

  @import url('https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap');
  

  • And then, since all elements will use the same font-family, you can type this code in your CSS:

  * {
     font-family: 'Outfit', sans-serif;
  }
  

  0