A bit of css grid and animations

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Arturo Simon! 👋

  Haha—I also hopped into this challenge thinking positioning the background images would be a breeze and then left to do something else after like half an hour of calc() and viewport size units! 😅

  You've done a nice job, once again, and I like that subtle animation to the background images! 😎

  Happy coding! 😁

  1

  ---

  

  Arturo Simon•1,785

  @artimysPosted almost 4 years ago

  @ApplePieGiraffe I will add that one of your previous designs inspired the bg animation. Thanks

  0
• 

  Abhishek Rawat•690

  @AbePlaysPosted almost 4 years ago

  The animation looks dope. Loved it!

  1

  ---

  

  Arturo Simon•1,785

  @artimysPosted almost 4 years ago

  @AbePlays Thank you

  0
• 

  Anna Leigh•5,135

  @brasspetalsPosted almost 4 years ago

  Hi, Arturo! 👋 I usually shy away from commenting on challenges I haven't completed myself, but wanted to let know I thought your solution was excellent! I particularly like the background animation on the desktop version, which I'm bookmarking for reference.

  Poking around the code, I think I know of a simpler way of positioning the .profile-card__hero. Instead of absolute positioning, you could use display: flex along with align-items: center and justify-content: center on your .profile-card__header. Then just add margin-top: 140px (the height of the header) to .profile-card__hero. Your solution works perfectly, and there's probably a good reason you did it that way (I'm definitely still a newbie), but I thought I'd throw it out there just in case!

  1

  ---

  

  Arturo Simon•1,785

  @artimysPosted almost 4 years ago

  @brasspetals, thanks for poking around because I like your suggestion way better and already implemented it. The animated background was influenced by one of @ApplePieGiraffe designs. I thought it was cool too.

  Your feedback is priceless, thank you

  1

  

  Anna Leigh•5,135

  @brasspetalsPosted almost 4 years ago

  @artimys Excellent - happy to have helped!

  APG always bringing the animation game, it's true. 😄

  0