4th Challenge: profile card

Community feedback

• 

  Adrian H•420

  @AdrianX19Posted almost 3 years ago

  Hi @DrunkenNeoguri,

  Good job! if you'd like to get rid of this accessibility issue you can change <div class="namespace"> element to <h1> - keep in mind that if you do so you will have to adjust some styles as well!

  Marked as helpful

  1

  ---

  

  drunken_neoguri•290

  @DrunkenNeoguriPosted almost 3 years ago

  @AdrianX19

  Thanks for letting me know, I'm taking care of the h1 tag in future challenges as well!

  thank you! ^^

  0
• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @DrunkenNeoguri ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it. Especially I like the way you did background.

  Here are some of the tips I like to provide.

  • Please try BEM for naming element classes. It will help you a lot on bigger projects.

  https://www.frontendmentor.io/solutions/profile-card-solution-m-cH4D2Lp

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  1

  ---

  

  drunken_neoguri•290

  @DrunkenNeoguriPosted almost 3 years ago

  @tymren608

  Thanks for letting us know about the BEM method, we are taking this into consideration in future challenges as well.

  At first, I had no idea how to write it, but there was an article that someone explained to me in Korean, my native language, so I studied how to use it by referring to the article and the link given as an example.

  I learned a lot. thank you! ><

  0