4 Card Feature - HTML, CSS Grid

Community feedback

• 

  (Rezzak) MOHAMED ERRAZAK ALLAH•170

  @Rezzak48Posted over 3 years ago

  Hi Tom, I took a look at you code, it looks good! well done job! here is my tips to make your code better:

  • for the responsive layout, try to make like a tablet version, for example in your design you can do two cards in every row between 700px and 990px, and this is how you will keep it responsive and for the mobile version you already did well!
  • another thing I notice is the design is not centered, there is many ways to do it but I suggest to use the flex box on the body element : body { display : flex; justify-content : center, align-items : center }

  If you found my tips helpful, do not hesitate to mark it as helpful or upvote it, so others can see it first.

  happy coding 😊

  Marked as helpful

  0

  ---

  

  Tom•115

  @Tom2612Posted over 3 years ago

  @errazakallah31 Thanks! I wanted to go 100% Grid in this challenge just to try it out and see what I can/can't do with it. Your suggestion about a tablet-sized design is very helpful though.

  I see it is not centred, but when I click 'preview site' it looks aligned to the centre, is there something I am missing here? I will keep your advice in mind and apply some flex to my next challenge, thanks again!

  0