4 Card Feature Component

Community feedback

• 

  Devmor•470

  @devmor-jPosted over 2 years ago

  Hey, nice job 😀! Don't wanna be the guy who complains about padding, color, font properties and some other similar stuff because that is not the main goal here; I am pretty sure spending time on these tedious tasks, is not gonna be fun!

  So that being said I suggest adding lang="en" to your html tag. This simple attribute makes your html more solid and accessible.

  Translation services, screen readers and narrator's accent all rely on 'lang=?' attribute (for example lang="en-US" tells narrator's voice engine to use the accent of English spoken in United States of America).

  If you wanna know more about it please read this great article.

  Scaling cards on mouse hover is a nice effect and fits this project well 😍.

  I'm not sure using role="main" is as good as putting main content in <main> tag 🤔:

  <div class="container" role="main">
      ...
  </div>
  

  Overall the job is done and works fine, just provided some personal hints and hope that helps.

  Happy coding dear and cheers 🤩

  Marked as helpful

  0