4 Card Challenge w. CSS Grid

Community feedback

• 

  Milan Dordevic•165

  @milan93djordjevicPosted over 4 years ago

  I think you should try using less divs... For example you don't need that class container... Try to stick with semantic markup as much as you can and do some research on accessibility while you at it... Also I wouldn't (actually I didn't) use grid on cards itself. I finished also this project yesterday. It's not wrong to use it but seems easier with flex. Maybe you are practicing css grid so you try to use it as much as possible? Also that max-width: 2000px doesn't make sense because desktop version says it's 1400-something px if I'm not wrong... So I'd use that max-width instead... Lastly I don't know why you used pseudo::after for top borders? You wanted to try it out? It's much easier with border-top: ; Hope this help you to become better.

  1