3-columns challenge

Community feedback

• 

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  Hi Francis,

  Nice work on with this one, some small tweaks like the others have suggested and it'll be perfect.

  • i think you could add transition: ease .3s; to your buttons so the hover effect is smoother
  • also you're adding the border to them on hover which is making the buttons jump slighly, add it before

  Hope that helps a little bit more Happy coding!

  Marked as helpful

  1

  ---

  

  Francis•260

  @FrancisKhaledKhodjaPosted almost 3 years ago

  @darryncodes thanks for your feedback

  0
• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  To get rid of the accessibility/HTML issues shown in your Report:

  • change div.attribution to footer.attribution in your HTML
  • <section> and <article> usually need a heading; so if you don't need a heading in it, use some other element such as <div>

  Great job Francis!!! :)

  Marked as helpful

  1

  ---

  

  Francis•260

  @FrancisKhaledKhodjaPosted almost 3 years ago

  @anoshaahmed Thanks a lot. I appreciate your advise

  1
• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Hey @FrancisKhaledKhodja

  You did quite a nice job on your final solution. Based on what I've seen, here are a few suggestions that I hope will be useful to you:

  • Remove the background color on the .container element

  • Only the first and last cards have rounded edges. The first one has rounded edges on its left side and the last one has rounded edges on its right side. Of course this changes when you have smaller screen sizes

  • On the larger screen sizes, there's a small gap between the second and third card that's quite visible

  • I think the background color might be slightly different as well. Double check it to make sure

  • Try to refrain from using absolute positioning when building column based layouts such as this one

  • Try to not use fixed values for your width and / or height property when building layouts

  Marked as helpful

  1