3-column-prewiew-card-component

Community feedback

• Account deletedPosted over 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “car images/icons” in this component are purely decorative; They add no value. So their Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The anchor tag will achieve this.

  • The button styling is not correct; it should be a solid light grey hsl(0, 0%, 95%) and when hovered a light grey border should appear.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  00
• 

  Adriano•42,890

  @AdrianoEscarabote

  Posted over 2 years ago

  Hi mmmelomano, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:

  I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Learn More, he is not confirming a form, or something like, it will be redirected to another page, to Learn More!

  To resolve to do this:

  <a href=""/">Learn More</a>

  The rest is great!

  I hope it helps... 👍

  00
• 

  Jishan•290

  @jish0101

  Posted over 2 years ago

  Change the background colour and cards sizes, a bit bigger rest is good

  00