Design comparison
Solution retrospective
I have a problem with making my site responsive when changing size of browser.
Community feedback
- @HassiaiPosted almost 2 years ago
Remove the min-height from the cyan- -container, the yellow -- container and the green--container in the wrapper class. Using the min-height won't make the page responsive, using only padding is enough. change the font-size and font-weight of the button. Aside from this, everything is great. Happy coding.
Marked as helpful1 - @AdrianoEscarabotePosted almost 2 years ago
Hi Dekroo_, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To make the page more similar to the example layout, we can use a background color in the body:
body { backgronud-color: #f2f2f2; }
Images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty
alt=""
and addaria-hidden="true"
attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.To improve the structure of the html document, prefer to wrap all the content with the
main
tag, since this challenge is just a component, it needs amain
tag to know what the main content of the page is!The rest is great!
I hope it helps... 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord