Skip to content
Submitted over 2 years ago

3-column-preview-card-using-grid

Shehab Sha'lan•30
@shehabshalan
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...3-column preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Ahmed Bayoumi•6,740
    @Bayoumi-devPosted over 2 years ago

    Hey Shehab, It looks good!... You have accessibility issues that need to fix.

    • Documents must have <title> element to aid in navigation
    <head>
   //...
   <title>3-column preview card component | Frontend Mentor</title>
</head>
    • Using more than one <h1> is allowed by the HTML specification, but is not considered a best practice. Using only one <h1> is beneficial for screenreader users.

    ---> Multiple <h1> elements on one page

    I hope this is helpful to you... Keep coding👍

    1
    Shehab Sha'lan•30
    @shehabshalanPosted over 2 years ago

    @Bayoumi-dev Thanks. I will update my code.

    0
  • Okafor Raphael•240
    @OkaforRaphPosted over 2 years ago

    Hey Shehab, congratulations on completing the challenge! You did a great job 😉

    Just a tip for optimizing your code:

    • Always make use of relative units of measurement like "rem" instead of px.

    Hope this help! Happy coding 😁

    0
    Shehab Sha'lan•30
    @shehabshalanPosted over 2 years ago

    @OkaforRaph thanks for the tip.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord