3-column-preview-cards 🎴

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Mustafa! 👋

  Good effort on this challenge! Your solution responds well.Here's my few suggestions:

  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
  • Try to work on the class names, they are non-intuitive and hard to read in the code. Even tho i know what card c1 is in your code, after some time if I look at the code and i'll see just c1 class i wouldn't know what it is.
  • Since your icons images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.

  Good luck with that, have fun coding! 💪

  0
• 

  Eric Salvi•1,350

  @ericsalviPosted over 3 years ago

  Hey looks awesome. I am seeing a weird break-point on screens less than 575px in width. Just double check that to make sure you are responsive for most mobile devices.

  I would also take a look at paragraph fonts as they seem a bit too bold at that size. I think they should be using the font family from "Lexend Deca'" which will help with the accessibility for readability.

  0