@correlucas
Posted
👾Hello @kalosFestus, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
1.Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class
to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.
2.Don’t use id
to give the style of your elements, it's not a good idea because id
is a too specific selector used for forms
and Javascript code. Instead, use class
for styling and let the id
for much specific stuff. It's also not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later.
✌️ I hope this helps you and happy coding!
Marked as helpful