Submitted
@abhinavrai10
Need feedback on code quality. Any suggestions are highly welcomed.
@alanard
Posted
I think you need to add border-radius = "5px" to make it look even more similar to the original design
so far so good
Marked as helpful
@abhinavrai10
Posted
@alanard Thank you so much for taking out time and providing such a helpful feedback.
I have made the changes as recommended by you. I hope its better now.
@VCarames
Posted
Hey @abhinavrai10, some suggestions to improve you code:
The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.
The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
Your button needs to have solid white background; currently it is a full grey.
Happy Coding! 👻🎃
@abhinavrai10
Posted
@vcarames Thank you so much for taking out time and writing such a helpful feedback.
I have made the changes as recommended by you.
Everything is fine but as I make the changes, I got some Accessability issue here. It says "Page should contain a level-one heading".
I think its expecting H1 here. What's your thought here?
I mean, should i ignore this or is there any workaround?
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
