Design comparison
SolutionDesign
Solution retrospective
Hey! Thank you for your recommendations :)
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @lvisana 👋🏻
I have a couple of suggestions to help you fix the accessibility issues
- First, in HTML,
<section class="big-section">...</section>
should be<main class="big-section">...</main>
and<div class="attribution">...</div>
should be<footer class="attribution">...</footer>
. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues. - Next, for the car icons, add
aria-hidden="true”
, because they're for decoration. For example,<img src="./images/icon-sedans.svg" aria-hidden="true” class="icon-container">
. You can read more aboutaria-hidden
here. - Also, I suggest adding
transition: all 0.2s;
to the button so that the state of:hover
happens smoother.
I hope this was helpful 👨🏻💻 all in all, for the third project you made a really good progress, keep it up. Cheers 👾
Marked as helpful0 - First, in HTML,
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord