Design comparison
Community feedback
- @Kamlesh0007Posted over 1 year ago
Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. When it comes to centering a div or any element on a webpage, using margins may not always be the best approach. so use flexbox or grid layout for centering the div
body { height: 100vh; font-family: var(--lexend-deca); font-size: 15px; display: grid; place-items: center; } remove below lines of code .container { margin: 140px 265px 10px 0; margin-top: 140px; margin-left: 200px; }
Marked as helpful0@mohamedibra227Posted over 1 year agowill you believe me if i told you that i did that intentionally :) that way some one will acutely comment and leave a feedback so i can find out where i am and what can i work on . but i appreciate you so much my friend for the kind words ... thank you <3 @Kamlesh0007
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord