3-column-preview-card-component-main HTML and CSS

Community feedback

• 

  Mennatallah Hesham•1,490

  @Mennatallah-HishamPosted about 1 year ago

  Hi Muhammad ,

  You did great 👍

  here are some suggestions to improve your code:

  Headings

  • it is not a good practice to have multiple h1 , it confuses assistive technology users.
    I suggest you add an <h1> to be accessible to SEO and assistive technology users and hide it from UI . then change your <h1> to <h2>

  Icons

  • add aria-hidden="true" to icons, it is used to hide decorative content/images/icons from screen readers which improves their experience

  Mark up

  • most of your divs can be replaced with <Article> / <section> for better semantics

  here are some helpful articles

  • <article>/<section
  • heading best practices

  Hope you find this helpful, Happy Coding

  Marked as helpful

  0

  ---

  

  Muhammad Qasim Fiaz•190

  @MuhammadQasimFiazPosted about 1 year ago

  @Mennatallah-Hisham Thanks for commenting... kindly review again and share your suggestions

  0