3-column-preview-card-component-main

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hi Abdulbasit Fasasi,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • Use the <main> landmark for the component that wraps the three cards, <footer>landmark to wrap the attribution, as using landmarks is important to improve navigation experience on your site for users of assistive technology.

  • About <h1>it is recommended not to have more than one h1 on the page. Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility. Then swap those <h1> by <h2>.

  • In this challenge, the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images.

  • What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  • Add border-radius andoverflow hiddento the main container that wraps the three cards so you don't have to set it to individual corners.

  • Don't capitalize in html, let css text transform take care of that. Remember screen readers won't be able to Read capitalized text as they will often read them letter by letter thinking they are acronyms.

  Overall, your solution looks great, Hopefully this feedback helps.

  0
• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  👾Hello ABDULBASIT, congratulations for your new solution!

  Here's some tips to improve your solution:

  To make the container have the proper alignment, add body min-height: 100vh to make the body display 100% of the browser screen size and display: flex e flex-direction: column to align the child element vertically using the body as reference.

  body {
      min-height: 100vh;
      background-color: hsl(0, 0%, 95%);
      font-size: 15px;
      display: flex;
      flex-direction: column;
      align-items: center;
      justify-content: center;
  }
  

  To improve the semantics you can replace the div that wraps the card with <article>

  Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp

  👋 I hope this helps you and happy coding!

  0