Design comparison
Solution retrospective
feedbacks are appreciated
Community feedback
- @EnidaShehuPosted over 1 year ago
Good job on your solution!
To make the container edges round you can add the classes and CSS code below:
.cont-1 { border-top-left-radius: 0.5rem; border-bottom-left-radius: 0.5rem; }
.cont-3 { border-top-right-radius: 0.5rem; border-bottom-right-radius: 0.5rem; }
I would also advice you to use rem instead of px when sizing elements. The main advantage of using rem units is their scalability and responsiveness. When you define sizes using rem, they adjust proportionally to the font size of the root element. This means that if you changes the default font size in their browser settings, all elements specified in rem will automatically adapt accordingly.
Keep it up :)
Marked as helpful1 - @NehalSahu8055Posted over 1 year ago
Also
- Your cards are not centered on the screen.
- To center card on the page.
- USING FLEXBOX
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
- USING GRID
body{ min-height: 100vh; display: grid; place-items: center; }
Marked as helpful0 - @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨ Give you cards some
width
or more specificmax-width
as it will become very large on larger screens.➨ Use
Semantics
for proper design of your code.<body> <header> <nav>...</nav> </header> <main>...</main> <footer>...</footer> </body>
or alternatively
<body> <div class="container" role="main"> /html code goes here: 📃 </div> </body>
I hope you find this helpful.
Happy coding😄
Marked as helpful0 - @Kamlesh0007Posted over 1 year ago
Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. The styling of button is not as per design u need to make the button transparent on hover only else the button will have the background color of the card and before hover make the background of button white not transparent
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord