3-column-preview-card-component-main

Community feedback

• 

  Somnath Waghmare•70

  @itssumoPosted over 3 years ago

  ohk I'll Improve that I am still new to this thanks for the suggestions

  0
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on this one. Layout in desktop is good though why did you not create the mobile state here. It will be really beneficial that whenever we submit solutions, making sure that it is completed okay.

  Suggestions would be that:

  1. On the desktop, if you inspect your layout in dev tools from the bottom, you will see that the sizes of the cards scale, because you are using height: % but the problem is that, your element is absolute which I think is not the ideal property on this. Since they are absolute, they are relative to the parent, but since the parent body is not relative, therefore the cards takes on the viewport which is not good. Instead of %, use other units like rem.

  1.1. Also It will be really good to use other property here and not using position: absolute. You can make the body have a display: flex to achieve that layout really well.

  2. Do not use multiple h1 tags in a page. It may beneficial to use h1 on this, but sr only or screen reader only. Then use other header tags like h2 to those titles.

  Those only, but that position: absolute I think is not the proper choice in here. Use some flexbox or grids, that will be really awesome. The mobile layout as well, creating them is necessary.

  But still, good job on this^

  0