3-column-preview-card-component-main

Community feedback

• 

  darryncodes•6,370

  @darryncodesPosted about 3 years ago

  Hi Mariusz,

  Great design, very responsive too - well done!

  • you could add max-width: 320px; .column so your card doesn't stretch across the whole of the viewport at the mobile break point
  • you could add align-self: flex-start; to your <button> to stop the button from stretching all the way across the card
  • it's best practice to not use id's for styling
  • if you add an alt-text to your images and change <div class="mainContainer"> to <main class="mainContainer"> you'll clear your accessiblity report

  Good luck with it all!

  1

  ---

  

  Mariusz Olszewski•360

  @molszewski34Posted about 3 years ago

  @darryncodes yes, that is great idea to add max-width to it. Thanks for advice. Why it is not good idea to use id's for styling?

  0

  

  darryncodes•6,370

  @darryncodesPosted about 3 years ago

  you're welcome @molszewski34 glad it has helped! This article does a really good job of explaining some reasons why

  1

  

  Mariusz Olszewski•360

  @molszewski34Posted about 3 years ago

  @darryncodes thank you. Next week i plan to upload few more solutions. I would realy appreciete if you would just look at them and share your thoughs.

  0

  

  darryncodes•6,370

  @darryncodesPosted about 3 years ago

  of course @molszewski34, I’ll do what I can to help!

  0