3-column-preview-card-component-by-misiaczekooo

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @MisiaczekOOO, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  1.Add the correct color for the background, that in this case is background-color: #F2F2F2

  2.Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  MisiaczekOOO•50

  @MisiaczekOOOPosted about 2 years ago

  @correlucas Thank you very much for your feedback! Hope you will see my other solutions and check them out too!

  Thanks :D

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @MisiaczekOOO, some suggestions to improve you code:

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your car images/icons to fully remove it from assistive technology.

  • The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.

  • The buttons should be a solid white, instead they are a solid grey.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  Happy Coding! 👻🎃

  Marked as helpful

  1