Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3-column-preview-card-component USING HTML CSS

@Huzaifa1910

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hi Mohammad, great job! I took some time to look at your code and for improving it:

  • add main tag and wrap the cards for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • remove height from cards class
  • remove all margin from main class because with flex they are superfluous and add width: 100%;
  • add min-height: 90vh to main class because Flexbox aligns child items to the size of the parent container
  • With font-family:" Big Shoulders Display ", cursive the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with a font-family:" Big Shoulders Display ", sans-serif much more similar to the primary font.

Overall you did well 😉 Hope this help!

Marked as helpful

1

@Huzaifa1910

Posted

@denielden THANKS FOR YOUR FEEDBACK I'VE TRIED WHAT YOU HAVE SUGGESTED AND IT HAS WORKED...... I WANT TO KNOW ARE U SUGGESTING TO WRAP ALL CONTENT IN MAIN TAG OR WRAP EACH CARD??

1
Travolgi 🍕 31,420

@denielden

Posted

@Huzaifa1910 You are welcome! Wrap all the contents :)

1

@Huzaifa1910

Posted

@denielden Yeah i've done it brother...THANKS

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord