Travolgi 🍕• 31,420
@denielden
Posted
Hi Mohammad, great job! I took some time to look at your code and for improving it:
- add
main
tag and wrap the cards for improve the Accessibility - add descriptive text in the
alt
attribute of the image - remove
height
fromcards
class - remove all
margin
frommain
class because with flex they are superfluous and addwidth: 100%;
- add
min-height: 90vh
tomain
class because Flexbox aligns child items to the size of the parent container - With
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with afont-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font.
Overall you did well 😉 Hope this help!
Marked as helpful
1
@denielden THANKS FOR YOUR FEEDBACK I'VE TRIED WHAT YOU HAVE SUGGESTED AND IT HAS WORKED...... I WANT TO KNOW ARE U SUGGESTING TO WRAP ALL CONTENT IN MAIN TAG OR WRAP EACH CARD??
1
Travolgi 🍕• 31,420
@denielden
Posted
@Huzaifa1910 You are welcome! Wrap all the contents :)
1
@denielden Yeah i've done it brother...THANKS
1