3-column-preview-card-component using Flex

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @TaskinSultana, Congratulations on completing this challenge!

  I saw your solution preview site and I think it's already really good. Here’s some tips for you to improve it:

  Improve your html markup using meaningful tags to wrap the content, you can replace the div you’ve used for each card with <article>. Remember to wrap big blocks of content with semantic tags and never divs, use divs for small blocks. Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Taskin Sultana•190

  @TaskinSultanaPosted about 2 years ago

  @correlucas Thank you :)

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi,

  Congratulations on completing the challenge

  Height issue are most likely being caused by the min-height you set.

  .flex {
      min-height: 70vh; 
  }
  

  remove the above declaration and the height issue will go away. Because you set a min-height the child elements stretched to the height of the parent which is the default for flexblos.

  To center the columns or any card in the middle of the page add the following.

  body {
      display: flex;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  

  Hope this is helpful

  Marked as helpful

  0

  ---

  

  Taskin Sultana•190

  @TaskinSultanaPosted about 2 years ago

  @hyrongennike Thank you so much :)

  0