3-column-preview-card-component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi @Jmlsoteyza, congrats on completing this challenge!

  I've just opened your live site and I can say that you did a great job putting everything together! There's some tips to improve your solution:

  1.Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  2.Use max-width: 100% for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).

  @media screen and (max-width: 1000px)
  main {
      height: 100%;
      /* width: 20em; */
      max-width: 100%;
      flex-direction: column;
  }
  

  3.Improve your html markup using meaningful tags to wrap the content, you can replace the div you’ve used for each card with <article>. Remember to wrap big blocks of content with semantic tags and never divs, use divs for small blocks.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  2

  ---

  

  jom•130

  @JmlsoteyzaPosted about 2 years ago

  @correlucas Thank you man, I'll take note of your tips. Actually I'm having struggle of those. But I've learned more by receiving feedback from others

  0