3-column-preview-card-component || SASS ||

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To properly center your content to your page, you will want to add the following to your Body element (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  • The “car images/icons” in this component are purely decorative; They add no value. So their Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  • The headings in your component are being used incorrectly. Since the <h1> heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an <h2> heading since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The Anchor Tag will achieve this.

  • Your buttons should be a solid white. Currently is a solid gray.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  1
• 

  Rahul Saini•110

  @RahulnerdyPosted almost 2 years ago

  Thankyou, i will make the required changes.

  0