3-column-preview-card-component

Community feedback

• 

  Mayank Arora•430

  @mayankdrvrPosted about 1 year ago

  Congratulations sonu9889 for completing this challenge. Your design matches the solution very well and your code is following good practices.

  Here are a few observations-

  1. Avoid using <div> element in html file and use semantic html elements throughout the code for better web accessibility.
  2. Try to use the Block Element Modifier(BEM) naming method as a good practice of naming classes for referencing html elements in the css file.
  3. Using noopener and noreferer in <a> elements is a good security practice with cross browser compatibility.
  4. The h1 should be used for SEO, but it should be used only once.

  Awesome solution and keep it up.

  Marked as helpful

  1

  ---

  

  sonu9889•20

  @sonu9889Posted about 1 year ago

  Thank you @mayankdrvr for the code review. I will implement these changes from now on.

  1