Design comparison
Solution retrospective
Are there any potential improvements in my code structure? What best practices should I consider for a more efficient implementation? Any recommendations for enhancing the overall user experience? Are there alternative approaches or advanced techniques I could explore?
I trying to use CSS variables so any advice on this subject is welcome 😁
Community feedback
- @MelvinAguilarPosted 10 months ago
Hello there 👋. Good job on completing the challenge !
I have one suggestion about your code that might interest you.
- Not all images should have alt text. Car icons are for decoration purposes only, so they can be hidden from screen-readers by leaving its alt attribute empty. You can read more about this here 📘.
I hope you find it useful! 😄
Happy coding!
Marked as helpful0@404diabyPosted 10 months agoHello @MelvinAguilar !! Thanks you for comment, your advice. it is very useful to me
0 - @Zy8712Posted 10 months ago
Your site looks great, good job!!!
The only things I'd change is your use of the page headers. I saw that you used
<h3>for the headers of each section. Headers should be used in order from<h1>to<h6>without any skips. So my suggestion would be to make each of the headers from the three sections<h2>tags. Then you add a hidden<h1>tag that acts as a page title.All the headesr come with a default font size, which can be changed using the
font-sizeproperty in your css. Hope this helps 👍Marked as helpful0@404diabyPosted 10 months agoHello @Zy8712 !! . Thanks you for comment, your advice. I think I understood what you meant. I’ll try to apply it
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord