3-column-preview-card-component/ Flexbox/ CSS custom properties

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEIGHT 📐:

  • Use min-height: 100vh for .car-types instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the .car-types will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the .car-types will start at 100vh, if the content pushes the .car-types beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  ShyamCanCode•90

  @ItachidorriPosted over 1 year ago

  I forgot to tell, I was unable to color the text inside buttons due to specifity issues, I think so. Can anyone check how can it be solved?

  0