@VCarames
Posted
Hey @niccolashernandez, some suggestions to improve you code:
-
The icons are decorative images, there alt tags should be blank.
-
The backquote is being used incorrectly. This paragraph isn't a quote a simple paragraph element will do fine.
-
Your "buttons are created incorrectly and aren't accessible. This buttons, when clicked, should direct the user to a different page in your site. So this should be anchor tags.
-
Your attribution class should be wrapped in a footer element.
-
Look into expanding your CSS Reset, you only have one. Here are some links:
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
- To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
More Info:
https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9
Marked as helpful