Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @NamlidN, some suggestions to improve you code:
- Your card is not responsive. You want to use responsive properties and media queries.
Here is a Google Developers link that will teach you how to create responsive designs:
- To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
<body> <main> <article> <article class="sedan-card"></article> <article class="sedan-card"></article> <article class="luxury-card"></article> </article> </main> </body>The Main Element identifies the main content of the document.
While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.
Lastly, each card will be wrapped in their own Article Element because they too, are complete, or self-contained, section of content that is, in principle, independently reusable.
More info:
https://web.dev/learn/html/headings-and-sections/
- The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.
Happy Coding! 👻🎃
0 - @correlucasPosted about 2 years ago
👾Hello @NamlidN, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
Improve the card overall look adding the rounded borders to the first and the third card using a value around
border-radius: 14px.Use
max-width: 100%for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a
single classto manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.✌️ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord