3-column-preview-card-component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Manuel, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • the html comments start with <!-- not <--
  • Tip of graphic design: with font-family:" Big Shoulders Display ", cursive the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with a font-family:" Big Shoulders Display ", sans-serif much more similar to the primary font.
  • add main tag and wrap the card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the p container of image
  • remove all margin from motorcars class and body because with flex they are superfluous
  • use min-height: 100vh instead of height to body
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1

  ---

  

  Manuel•70

  @manny-GMPosted over 2 years ago

  @denielden Thank you so much for this tips, i appreciate them

  1