Submitted over 1 year ago

3-column-preview-card-component

Satyam Raj•160

@Satyaaam

Preview site View code

This is a solution for...3-column preview card component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

Please rate my Project out of 5. I had some problems while making this like

Alignment of all the text properly.
After applying media query my upper part is not visible, I don't know how but it is still not visible in crome.

Community feedback

C H A R A N 🎯•2,670
@0xabdulPosted over 1 year ago
Hello Developer well congratulations on successfully completing the 3-column preview card component

A Few Feedback for improve your code

In Html 📃:

LANDMARKS 🚀

The main landmark role is used to indicate the primary content of a document. The main content area consists of content that is directly related to or expands upon the central topic of a document, or the main function of an application.

the html page should be contained one main landmark

to clear the Accessibility reports use sematic elements or non semantic elements..

Semantic elements ⚙️

<aside> <nav> <section> <main> <header> <footer> <article> Ect..

using semantic elements

Ex :

<html lang="en"> <head> <title>my page</title> </head> <body> <header> //logo img or heading ect... //Using heading only </header> <main> //Use only main of the contents </main> <footer> //use copy write discription or challenge d by front end mentor code by mark.. </footer> </body> </html>

And The Next Way using the Non - Sematic Elements Ex : <div> , <Span>

Example

<body> <div class="Container" role="main"> </div> <body>

HEADING ⚠️

The page must contain at least one h1 element identifying and describing the main content of the page. An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

So fix them

Ex :

<h1> </h1> <h2> </h2> <h3> </h3>

Note : we use the headings line by line in order way

I Hope you find the solution and it's useful comment for you your 3-column preview card component project doing very well Happy Coding Developer
Marked as helpful
0
Abdul Khaliq 🚀•72,560
@0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

So fix it by replacing the <div class="supreme"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

This solution had generated accessibility error report due to lack of level-one heading <h1>

Every site must want at least one h1 element identifying and describing the main content of the page.

An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord