Design comparison
Solution retrospective
Your feedback, send it this way🤟
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @DagimTizazu!
Your solution looks excelent!
I have just one suggestion:
- In order to make your HTML code more semantic, only use one
<h1>
per page - this should represent the main heading/title for the whole page. Unlike what most people think, it's not just about the size and weight of the text.
📌 The
<h1>
to<h6>
tags are used to define HTML headings.📌
<h1>
defines the most important heading.📌
<h6>
defines the least important heading.📌 Don't skip heading levels - start with
<h1>
, then use<h2>
, and so on.This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, you did a great job!
Marked as helpful0@DagimTizazuPosted 10 months ago@danielmrz-dev bro, there is no main heading/title for this page; there are three and since it's a bad practice to skip heading levels, I can't use <h2> tag without using <h1> first. So what do you suggest I do?
0@danielmrz-devPosted 10 months ago@DagimTizazu
You can use a hidden
<h1>
tag. Like a title above the card, but you can setopacity: 0
; ordisplay: none;
to it.1@DagimTizazuPosted 10 months ago@danielmrz-dev
Yeah but it will be confusing for someone reading the code. I would rather stick to the less semantic approach for these kind of challenges. But I have learned my lesson, thank you.
0@danielmrz-devPosted 10 months ago@DagimTizazu
I don't think it's confusing for someone reading the code, since the <h1> will be there... but sure, less semantic does the job just fine, it's just a detail 😊
0 - In order to make your HTML code more semantic, only use one
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord