3-column-preview-card-component

Community feedback

• 

  Adrian H•420

  @AdrianX19Posted almost 3 years ago

  Hi @mellaniecristine!

  Nice job! Just a few small suggestions:

  • you can solve you accessibility issues by changing your container 'div' to 'main' - it's worth to use semantic tags!
  • I see you set border radius for each card separately, to be more efficient you can add border radius for your parent container and then just add overflow: hidden and you will get same result
  • Top padding seems to be a bit too big, maybe try to play with this value a little bit ;)
  • I had a look into your css file and noticed that in your media queries you set flex properties for body even tough they are already set - to keep media queries clear it's good to put there only those properties which are changing, no need to repeat same ones :)

  Marked as helpful

  2

  ---

  

  Mellanie Cristine•70

  @mellaniecristinePosted almost 3 years ago

  @AdrianX19 wow! Thanks a lot 🤩. Very nice feedbacks, specially the second item. About the padding, I hadn't measure the exact space values for each element in this exercise haha, but you're right.

  0
• Account deleted

  nice!

  0