Design comparison
Solution retrospective
Hello every one, Please help my to improve my code by your rate and point of view.
Community feedback
- @BurritoDoggiePosted over 3 years ago
Hello PamyEbrahim,
Lovely effort! I enjoy it when you press a button it turns white. And it changes when you select another button. Sorry to say but I am not a very good programmer so I will not be able to correct you on any coding errors. I think you are a very good programmer especially compared to me. I always have trouble with positioning things and items which I think you did very well.
Keep Coding!
(•‿•)
1@RamyEbrahimPosted over 3 years agoHello Burrito , I would like to thank you for your beautiful words and you comment make my day, thanks for it. you will be a great programmer one day.
2 - @Nishkarsh01Posted over 3 years ago
Hello, Ramy Ibrahim Fawzy! 👋
Great Job on finishing another frontend mentor challenge! Here are few suggestions from me:
- Update the background color of body to background:
hsl(0, 0%, 95%);
- Change the color of each h1 to
#fff
orwhite
- Try rounding the corners of the boxes with CSS property
border-radius
by separately targeting the .box:nth-child(1) and .box:nth-child(3) . - Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
- Try using comments more often in code, the comments eventually help you and others to clearly understand the logic behind the code be it in any language.
Great effort! Keep Hustling, have fun coding! 💪
0@RamyEbrahimPosted over 3 years agoHi Nishkarsh, thank you so much for your help, i respect your point of view and i'll put it in consider for the incoming designs. And for your valued suggestions i'll update my design to do all of it. thanks and best regards for you.
1 - Update the background color of body to background:
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord