3-column-preview-card-component

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 3 years ago

  This is pretty good, well done

  Just a few points for improvement :

  • never put text in divs or spans alone. Always use a meaningful element eg paragraph
  • look up how and when to write alt text on images. I think these icons are decorative and therefore should have empty alt or role presentation on them
  • don't capitalise in html, let css text transform take care of that. Remember screenreaders won't be able to Read capitalised text as they will often read them letter by letter thinking they are acronyms
  • never have font size in px. Use rem
  • overall try to use rem more instead of px. This will make sure everything scales together no matter the font size settings someone has
  • it would be more performant to place border radius on the container and give it overflow hidden to make the rounded corners show
  • whenever you include interactive elements, make sure you include clearly visible focus-visible styles as well as hover ones

  Good luck

  0