Skip to content
Submitted over 2 years ago

3column-preview-card-component

#bem#sass/scss
Bilikisu Wunmi Olatunji•60
@BAderinto
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...3-column preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Kindly review my submission. I'm still working to improve myself in media queries. Thank you.

Community feedback

  • Hamzat Lawal•560
    @EngineerHamzieyPosted over 2 years ago

    Hello , you have done a great work To fix Your accessibility issues:

    • always add the language attribute to your <html> tag, it should look like <html lang="en"> , here en means English
    • All Your page content should be contained by landmarks like <header>, <main> ,<footer>, etc
    • your card should be wrapped in main as in,
    <main class="main">
 /*INSTEAD OF */ 
<div class="main">
    • Also div.attribution should be contained in the footer. i.e
    <footer>
  <div class= "attribution"></div>
</footer>

    Then you can go to accessibility issue and click the "regenerate accessibility report" button

    I think this will help....my EXPLAINED correction to someone's code

    github repository link

    live site link

    if you notice anything wrong, feel free to correct me I am not perfect, I am a beginner, I am open to correction and suggestions and I am wiling to learn more I'm doing this because I hope it will help feel free to ask questions,

    I hope this was helpful and my hope my bad grammar isn't giving you a hard time 😊.

    Marked as helpful
    0
    Bilikisu Wunmi Olatunji•60
    @BAderintoPosted over 2 years ago

    @EngineerHamziey Thank you for your feedback. It was really helpful.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord