@VCarames
Posted
Hey @CharlesSquirel, some suggestions to improve you code:
-
Your not using the Heading Element Correctly. The only headings in the challenge are the "SEDANS", "SUVS" and "LUXURY". All the other text have to wrapped in a Paragraph Element.
-
For this challenge, we are assuming that is it part of larger website. So your safe option is to use the <h2> Heading, because it will give each card the same level of importance and it's reusable.
-
For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
More Info:
https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9
- Your CSS Reset is extremely bare. You want to add more to it.
Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
Happy Coding!
Marked as helpful