3-column-preview-card-component

Community feedback

• 

  Hatem Henchir•530

  @hatemhenchirPosted almost 2 years ago

  Hey Malek, how are you ? I really liked the result of your project, but I have some tips that I think you will enjoy:

  • Change the height: 220vh; to min-height:100vh it will be centered.
  • you can let you button hover like this .btn1:hover { background-color: hsl(31, 77%, 52%) !important; color: hsl(0, 0%, 95%) !important; border: 1px solid hsl(0, 0%, 95%) !important; } .btn2:hover { background-color: hsl(184, 100%, 22%) !important; color: hsl(0, 0%, 95%) !important; border: 1px solid hsl(0, 0%, 95%) !important; } .btn3:hover { background-color: hsl(179, 100%, 13%) !important; color: hsl(0, 0%, 95%) !important; border: 1px solid hsl(0, 0%, 95%) !important; } `

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  1
• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Change the height: 220vh; in your ".container" class to min-height: 100vh; to have you component centered to your page.

  • The car images/icons in this component are purely decorative; They add no value. So their Alt Tag should left blank and have an aria-hidden=“true” to hides them from assistive technology.

  • The headings in your component are being used incorrectly. Since the <h1> Heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an <h2> Heading, since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should bedirected to a different part of you site. The <a> Anchor Tag will achieve this.

  • The button styling is not correct; it should be a solid white and when hovered the white border should appear.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  1