3-column-preview-card

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @fica25, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  • The icon doesn’t have an important role when you think about semantics and the html structure. So you can add aria-hidden=“true” to avoid it being found and read in the accessibility mode/screen readers. These are only decorative items.
  • Use max-width: 100% for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).

  ✌️ I hope this helps you and happy coding!

  1

  ---

  

  Filip•110

  @fica25Posted about 2 years ago

  @correlucas Hey, thanks for the feedback and advice. I'm very glad and pleased to get advice from a person like you. Happy coding.

  0