Design comparison
Community feedback
- Account deleted
Hello Coder your code is fantastic😊
And congratulations on successfully completing an another newbie challenge✨
And for you I have a small recommendation that might be helpful for you
<h1> tag :
It is mandatory to use a <h1> tag in your solution because <h1> tag is most important aspect in accessibility and it helps screen reader to navigate with your page in easy way
And H1 tags also help Google to understand the structure of a page. So if you're using H1s as Google recommends for your page title or content heading, your H1 is effectively telling Google “here's what my page is about.
And that's why I recommend you to use only one <h1> tag in your solution
Outline :
Did you notices that when you hover over buttons it shakes or moves a little, that is because a border takes up space in the document. To fix i'd suggest you use outline instead of border
And I also recommend you to check out my solution that will definitely going to help you
Hope I might be helpful ☺️
Marked as helpful1 - @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨ Use
min-height
instead ofheight
in<main>
➨ For Responsiveness
- Replace
width
withmax-width
and see the effect.
main section { margin: 20px; max-width: 330px; }
I hope you find this helpful.
Happy coding😄
Marked as helpful1 - Replace
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord