Design comparison
Solution retrospective
Feedback welcome! Starting to learn about flexbox and media queries.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello there! 👋
Good effort on making the site responsive! 👍
There are some things that you can do to make the site better.
- I would recommend making the
body
element as the flex container instead of thebox
element. Then, remove themargin
from thebox
element. By making thebody
element as the flex container, the cards should be perfectly in the middle of the page. - I recommend setting a
min-height
on thebody
element to make the cards vertically center. Also, add somepadding
on thebody
element to prevent the card from touching the edges of the browser. - The car icons are decorative images. I can tell it because if they don't exist then there would be no missing information.
That's it! Hope you find this useful! 😁
Marked as helpful0 - I would recommend making the
- @HanningtoneMPosted over 2 years ago
This comment was deleted over 2 years ago
0@vanzasetiaPosted over 2 years ago@HanningtoneM Hey, Hanningtone Monda! Next time, please avoid asking the solution author to mark your comment as helpful. It can put unnecessary pressure on the solution author to mark your comment as helpful, which is best avoided.
Also, It's best to help others without expecting anything in return. If the solution author marks your comment as helpful then it's a bonus. 🙂
To learn more about what you should and you shouldn't do, you can read the Frontend Mentor community guidelines.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord