Design comparison
SolutionDesign
Solution retrospective
Hello, community this is another pre-view card project that I have been doing, to learn more about css flex and how to style layouts. Hope it is up to the mark
Feedback Appreciated.
Community feedback
- @MelvinAguilarPosted about 2 years ago
Hi @AatifxShaikh ๐, good job on completing this challenge! ๐
Here are some suggestions you might consider:
- The
<h1>
element is the main heading on a web page. There should only be one<h1>
tag per page. The HTML Section Heading elements (Reference). This case requires thatSUVS
,SEDANS
, andLUXURY
be<h2>
elements. - The
Learn More
elements should beanchor
tags and not buttons because they redirect to another part of the page. - The container isn't centered correctly. You can use flexbox to center elements:
body { min-height: 100vh; display: flex; flex-direction: column; justify-content: center; align-items: center; }
Also, remove the margin from the
container
selector.Links with more information:
- The Complete Guide to Centering in CSS.
- A Complete Guide to Flexbox (CSS-Tricks).
- How TO - Center Elements Vertically (W3Schools).
- CSS Layout - Horizontal & Vertical Align (W3Schools).
I hope those tips will help you.
Good job, and happy coding!
Marked as helpful0@AatifxShaikhPosted about 2 years ago@MelvinAguilar Thank You for the feedback. Will look into the tips and will try to improve more.
1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord