Design comparison
Solution retrospective
Any and all feedback is welcome, getting back into the process.
Community feedback
- @TrakaMeitenePosted over 3 years ago
At the *(..) box-sizing:border-box; will be correct. I would rather use border box only *{ box-sizing:border-box;} cause margins affect the design. div. container height is too much. I would write height :100vh; But I'm not sure if it is the best practice. As the button tag has a border default, I would suggest to take it off : border:none; I would use @media so you could define margins for mobile view.
Clean code, it was easy to understand your work :)
1@monicamclaughlanPosted over 3 years ago@TrakaMeitene thank you so much! Still getting the hang of viewport height, and that makes sense too about the border on the button. Thanks again!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord