3-column-preview-card

Community feedback

• 

  xmat•160

  @mati0165Posted about 2 years ago

  Hi, nice that you have done that challenge, but i have some suggestions for you:

  • The best way to create a page is using divs not table like you do in that challenge. Also for that i would prefer using grid.
  • The page is not centered, but the best way to do that is when u use flexbox and add in css code min-height: 100vh for your body.

  Marked as helpful

  0

  ---

  

  Yathish•50

  @yathishgPosted about 2 years ago

  @mati0165 thanks for your feedback but I had another doubt can u pls tell me what is that two warnings showing in accessibility report

  0

  

  xmat•160

  @mati0165Posted about 2 years ago

  @yathishg Yes, its because u didint use <main> or/and <footer> in your code. There are a few landmarks in HTML5. When u add <main> after body those errors should disappear. Try to rebuild your code using landmarks and divs for placement on the site

  Marked as helpful

  0

  

  Yathish•50

  @yathishgPosted about 2 years ago

  @mati0165 got it ,thnks

  0