Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @Kevin-AC, some suggestions to improve you code:
- To center you content to your page, add the following to your Body Element:
body{ min-height: 100vh; display: grid; place-content: center ; }- To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
<body> <main> <article> <article class="sedan-card"></article> <article class="sedan-card"></article> <article class="luxury-card"></article> </article> </main> </body>The Main Element identifies the main content of the document.
While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.
Lastly, each card will be wrapped in their own Article Element because they too, are complete, or self-contained, section of content that is, in principle, independently reusable.
More info:
https://web.dev/learn/html/headings-and-sections/
-
The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.
-
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
Happy Coding! 👻🎃
Marked as helpful1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord