3-column-card using Utility Classes Solution

Community feedback

• 

  Karishma Garg•1,010

  @karishma-devPosted almost 3 years ago

  Hi @FarzeenKist, Your solution looks good and responsive.

  Things you can improve in your code:

  1. Instead of adding margin: 0 to different elements , you can add this to the universal selector. It will be applied to all the elements you are using.

  2.I noticed that there is no use of max-width: 100% in your img element.

  Hope this helps you. Good luck!

  1

  ---

  

  Farzeen Kistnareddy•60

  @FarzeenKistPosted almost 3 years ago

  Hey Krish , thank you for the tip about the universal selector. The reason I include all the elements I'm going to use instead of the universal selectors is because it allows me to also have a rough idea of what I'm going to use. But definitely worth including just in case I forget something. For the img part, are you sure? I've set the max-width: 100%; in the reset part of the StyleSheet. Have a good day/evening.

  0

  

  Karishma Garg•1,010

  @karishma-devPosted almost 3 years ago

  Yes, I tried to run your code and removed the max-width part from the img, it was working fine. But still, it would be better if you double-check it on your own. :)

  --I liked your use of clear comments in your stylesheet, it helped to see parts of your code clearly.

  1

  

  Farzeen Kistnareddy•60

  @FarzeenKistPosted almost 3 years ago

  Hey Karishma, I will double check it. Thank you, I've been constantly getting the advice of having clean/detailed code, so I've been working on it. Have a good day/evening : )

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Farzeen Good Job on challenge

  0

  ---

  

  Farzeen Kistnareddy•60

  @FarzeenKistPosted almost 3 years ago

  Hey Naveen, thank you!

  1