3-column

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 9 months ago

  Hi there, well done!

  A few tips:

  HTML:

  • You need to include the icons in your repo.

  • Alt text should be empty since these are decorative icons:alt="".

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Add around 1rem of padding on the body, so the card container doesn't touch the edges on small screens.

  • max-width on .cards should be in rem.

  • Media queries must also be in rem. I think the layout should be changed to 3 columns earlier. The cards seem to get a bit wide around 40rem (640px), so I would have that as the breakpoint.

  Marked as helpful

  0

  ---

  

  Sukruti Panigrahi•230

  @panigrahiSukrutiPosted 7 months ago

  Thanks for the helpful feedback on my frontend challenge! I'll definitely use your suggestions to get better. If you have any more tips or resources, I'd love to hear them. Thanks again

  1